fix scientific notation bug in interpolation#102
Open
drcmda wants to merge 1 commit intoanimatedjs:masterfrom
Open
fix scientific notation bug in interpolation#102drcmda wants to merge 1 commit intoanimatedjs:masterfrom
drcmda wants to merge 1 commit intoanimatedjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a bug in animated that is causing deeply nested side-effects.
This line will in some situations return a scientific number, which stringShapeRegex can't track, it thereby creates a wrong outputShape (for instance:
[-7]) which causes trouble later on. Basically it starts addingNanto the interpolated result, so output can look like this:1-e7NaNNaNNaNNaNNaNNaNdeg- and it's adding up, blowing up memory.I am not sure if the new regexp is covering all cases, but it fixed the problems i've had (an AnimatedValue visually stopped working).